Announcement Announcement Module
Collapse
No announcement yet.
programming nit in CasAuthenticationToken Page Title Module
Move Remove Collapse
This topic is closed
X
X
Conversation Detail Module
Collapse
  • Filter
  • Time
  • Show
Clear All
new posts

  • programming nit in CasAuthenticationToken

    It's creating intermediate Strings in the toString method with the + operator and then appending them to the StringBuffer. Instead of creating those unnecessary throwaway intermediate Strings, just append each bit on its own:
    Code:
        public String
        toString() {
            StringBuffer sb = new StringBuffer();
            sb.append(super.toString());
            sb.append("; Credentials (Service/Proxy Ticket): ");
            sb.append(this.credentials);
            sb.append("; Proxy-Granting Ticket IOU: ");
            sb.append(this.proxyGrantingTicketIou);
            sb.append("; Proxy List: ");
            sb.append(this.proxyList.toString());
    
            return(sb.toString());
        }

  • #2
    Logged as http://opensource2.atlassian.com/pro...browse/SEC-153

    Comment

    Working...
    X