Announcement Announcement Module
Collapse
No announcement yet.
FYI - Roo sources no longer build - broken on 29th Aug. Page Title Module
Move Remove Collapse
X
Conversation Detail Module
Collapse
  • Filter
  • Time
  • Show
Clear All
new posts

  • FYI - Roo sources no longer build - broken on 29th Aug.

    I have been succesfully building Roo from the spring git download for quite a while. I now find that the current master the branch i.e. 5428e5f09 no longer builds. Going back a few commits I see that -

    0ae4ba8e - Does not build
    ea4038ed - Does build

    Looking at the changes between the too commits and the output shown below I notice that two Test files are deleted by the commit.
    RespositryTest.java
    ResourceTest.java
    Could some test be trying to use them?


    The problem I get is shown below error marked in red

    This is not a moan, its just that I know we are getting near to Roo 1.2.0 and it MAY BE that this is a windows (my system) build issue, hence my report.

    Code:
    [INFO]
    [INFO] ------------------------------------------------------------------------
    [INFO] Building Spring Roo - Project 1.2.0.BUILD-SNAPSHOT
    [INFO] ------------------------------------------------------------------------
    [INFO]
    [INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ org.springframework.roo.project ---
    [INFO]
    [INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-versions) @ org.springframework.roo.project ---
    [INFO]
    [INFO] --- exec-maven-plugin:1.1.1:exec (default) @ org.springframework.roo.project ---
    [INFO]
    [INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ org.springframework.roo.project ---
    [INFO] Using 'UTF-8' encoding to copy filtered resources.
    [INFO] Copying 3 resources
    [INFO]
    [INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ org.springframework.roo.project ---
    [WARNING] File encoding has not been set, using platform encoding Cp1252, i.e. build is platform dependent!
    [INFO] Compiling 37 source files to C:\c\e_roo\roo-builder\project\target\classes
    [INFO]
    [INFO] --- maven-scr-plugin:1.7.2:scr (generate-scr-scrdescriptor) @ org.springframework.roo.project ---
    [INFO] Writing abstract service descriptor C:\c\e_roo\roo-builder\project\target\scr-plugin-generated\OSGI-INF\scr-plugin\scrinfo.xml with 9 entries.
    [INFO] Generating 8 Service Component Descriptors to C:\c\e_roo\roo-builder\project\target\scr-plugin-generated\OSGI-INF\serviceComponents.xml
    [INFO]
    [INFO] --- maven-resources-plugin:2.4.3:testResources (default-testResources) @ org.springframework.roo.project ---
    [INFO] Using 'UTF-8' encoding to copy filtered resources.
    [INFO] skip non existing resourceDirectory C:\c\e_roo\roo-builder\project\src\test\resources
    [INFO]
    [INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ org.springframework.roo.project ---
    [WARNING] File encoding has not been set, using platform encoding Cp1252, i.e. build is platform dependent!
    [INFO] Compiling 6 source files to C:\c\e_roo\roo-builder\project\target\test-classes
    [INFO]
    [INFO] --- maven-surefire-plugin:2.8:test (default-test) @ org.springframework.roo.project ---
    [INFO] Surefire report directory: C:\c\e_roo\roo-builder\project\target\surefire-reports
    [INFO] ------------------------------------------------------------------------
    [INFO] Reactor Summary:
    [INFO]
    [INFO] Spring Roo ........................................ SUCCESS [0.608s]
    [INFO] Spring Roo - Deployment Support ................... SUCCESS [0.250s]
    [INFO] Spring Roo - OSGi Bundle Module Parent ............ SUCCESS [1.108s]
    [INFO] Spring Roo - OSGi Roo Bundle Module Parent ........ SUCCESS [0.452s]
    [INFO] Spring Roo - Bootstrap ............................ SUCCESS [1.903s]
    [INFO] Spring Roo - OSGi Start Level Control ............. SUCCESS [1.623s]
    [INFO] Spring Roo - Support .............................. SUCCESS [2.355s]
    [INFO] Spring Roo - Support for OSGi Features ............ SUCCESS [1.279s]
    [INFO] Spring Roo - URL Stream API Contract .............. SUCCESS [1.155s]
    [INFO] Spring Roo - Shell ................................ SUCCESS [1.981s]
    [INFO] Spring Roo - Shell (OSGi Launcher) ................ SUCCESS [1.767s]
    [INFO] Spring Roo - URL Stream - JDK ..................... SUCCESS [1.422s]
    [INFO] Spring Roo - Shell - JLine ........................ SUCCESS [1.669s]
    [INFO] Spring Roo - Shell - JLine (OSGi Launcher) ........ SUCCESS [1.388s]
    [INFO] Spring Roo - Metadata ............................. SUCCESS [1.903s]
    [INFO] Spring Roo - User Agent Analysis (UAA) Integration  SUCCESS [1.748s]
    [INFO] Spring Roo - Felix Interoperability ............... SUCCESS [1.716s]
    [INFO] Spring Roo - Model ................................ SUCCESS [1.872s]
    [INFO] Spring Roo - File Undo ............................ SUCCESS [1.606s]
    [INFO] Spring Roo - File Monitor ......................... SUCCESS [1.248s]
    [INFO] Spring Roo - File Monitor - Polling ............... SUCCESS [1.233s]
    [INFO] Spring Roo - File Monitor - Polling (Roo Launcher)  SUCCESS [1.451s]
    [INFO] Spring Roo - Process Manager ...................... SUCCESS [2.168s]
    [INFO] Spring Roo - Project .............................. FAILURE [2.083s]
    [INFO] Spring Roo - Classpath ............................ SKIPPED
    [INFO] Spring Roo - Classpath (JavaParser Implementation)  SKIPPED
    [INFO] Spring Roo - Addon - toString ..................... SKIPPED
    [INFO] Spring Roo - Addon - JavaBean Method Manager ...... SKIPPED
    [INFO] Spring Roo - Addon - Plural Details ............... SKIPPED
    [INFO] Spring Roo - Addon - Property Files ............... SKIPPED
    [INFO] Spring Roo - Addon - @Configurable ................ SKIPPED
    [INFO] Spring Roo - Addon - Email ........................ SKIPPED
    [INFO] Spring Roo - Addon - JPA .......................... SKIPPED
    [INFO] Spring Roo - Addon - JMS .......................... SKIPPED
    [INFO] Spring Roo - Addon - Test Data On Demand .......... SKIPPED
    [INFO] Spring Roo - Addon - Automated Integration Testing  SKIPPED
    [INFO] Spring Roo - Addon - @Serializable ................ SKIPPED
    [INFO] Spring Roo - Addon - Entity ....................... SKIPPED
    [INFO] Spring Roo - Addon - Finder ....................... SKIPPED
    [INFO] Spring Roo - Addon - Logging ...................... SKIPPED
    [INFO] Spring Roo - Addon - Property Editor .............. SKIPPED
    [INFO] Spring Roo - Addon - Backup ....................... SKIPPED
    [INFO] Spring Roo - Addon - JSON ......................... SKIPPED
    [INFO] Spring Roo - Addon - Web MVC Controller ........... SKIPPED
    [INFO] Spring Roo - Addon - Web MVC JSP View ............. SKIPPED
    [INFO] Spring Roo - Addon - Web MVC Embedded Extensions .. SKIPPED
    [INFO] Spring Roo - Addon - Spring Security .............. SKIPPED
    [INFO] Spring Roo - Addon - Solr ......................... SKIPPED
    [INFO] Spring Roo - Addon - Web - Flow ................... SKIPPED
    [INFO] Spring Roo - Addon - Web Selenium Test Generator .. SKIPPED
    [INFO] Spring Roo - Addon - Google Web Toolkit ........... SKIPPED
    [INFO] Spring Roo - Addon - JDBC Driver Acquisition ...... SKIPPED
    [INFO] Spring Roo - Addon - Database Reverse Engineering . SKIPPED
    [INFO] Spring Roo - Addon - Creator ...................... SKIPPED
    [INFO] Spring Roo - Addon - RooBot Client ................ SKIPPED
    [INFO] Spring Roo - Addon - Op4J ......................... SKIPPED
    [INFO] Spring Roo - Addon - GIT .......................... SKIPPED
    [INFO] Spring Roo - Addon - Cloud Foundry ................ SKIPPED
    [INFO] Spring Roo - Addon - Service Layer ................ SKIPPED
    [INFO] Spring Roo - Addon - JPA Repository Layer ......... SKIPPED
    [INFO] Spring Roo - Annotations (ASLv2 Licensed) ......... SKIPPED
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD FAILURE
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 36.956s
    [INFO] Finished at: Tue Aug 30 22:22:20 BST 2011
    [INFO] Final Memory: 96M/230M
    [INFO] ------------------------------------------------------------------------
    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.8:test (default-test) on project org.springframework.roo.project: Ther
    e are test failures.
    [ERROR]
    [ERROR] Please refer to C:\c\e_roo\roo-builder\project\target\surefire-reports for the individual test results.
    [ERROR] -> [Help 1]
    [ERROR]
    [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
    [ERROR] Re-run Maven using the -X switch to enable full debug logging.
    [ERROR]
    [ERROR] For more information about the errors and possible solutions, please read the following articles:
    [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    [ERROR]
    [ERROR] After correcting the problems, you can resume the build with the command
    [ERROR]   mvn <goals> -rf :org.springframework.roo.project
    C:\c\e_roo\roo-builder>

  • #2
    Did you try removing your Git repo and re-cloning it? I don't see any issues today.

    Comment


    • #3
      It may be a problem with missing &quot;UTF-8&quot; defs?

      Hi Alan
      I did suspect that you were not seeing this issue in your builds.

      Taking your question as a request I did just as you asked and also removed my nexus and started from an empty default local repo cache. Using a virgin Maven 3.0.3 (from STS 281M1) it - of course - still fails and/or succeeds exactly as described earlier.

      But reading the actual error message tells me to go and look at the surefire reports - see the one shown below - {GUESS - could the lack of a missing UTF8 statement be what causing my windows build sys to see the problem?}

      I have also attached all the reports for the failing module in a zip. One successeds the others fail.
      I hope this helps.

      Code:
      -------------------------------------------------------------------------------
      Test set: org.springframework.roo.project.ExecutionTest
      -------------------------------------------------------------------------------
      Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.031 sec <<< FAILURE!
      testGetElementForMinimalExecution(org.springframework.roo.project.ExecutionTest)  Time elapsed: 0.016 sec  <<< FAILURE!
      org.junit.ComparisonFailure: expected:<..." encoding="UTF-8"?>[
      <execution>
          <id>some-id</id>
          <phase>test</phase>
          <goals>
              <goal>lock</goal>
              <goal>load</goal>
          </goals>
          <configuration>
              <sources>
                  <source>src/main/groovy</source>
              </sources>
          </configuration>
      </execution>]
      > but was:<..." encoding="UTF-8"?>[
      <execution>
          <id>some-id</id>
          <phase>test</phase>
          <goals>
              <goal>lock</goal>
              <goal>load</goal>
          </goals>
          <configuration>
              <sources>
                  <source>src/main/groovy</source>
              </sources>
          </configuration>
      </execution>
      ]
      >
      	at org.junit.Assert.assertEquals(Assert.java:123)
      	at org.junit.Assert.assertEquals(Assert.java:145)
      	at org.springframework.roo.project.ExecutionTest.testGetElementForMinimalExecution(ExecutionTest.java:104)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      	at java.lang.reflect.Method.invoke(Method.java:597)
      	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
      	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
      	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
      	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
      	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
      	at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
      	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
      	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
      	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
      	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
      	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
      	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
      	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
      	at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
      	at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
      	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:119)
      	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:101)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      	at java.lang.reflect.Method.invoke(Method.java:597)
      	at org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103)
      	at $Proxy0.invoke(Unknown Source)
      	at org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150)
      	at org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:91)
      	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69)

      Comment


      • #4
        This could be an issue. Andrew Swan will follow it up

        Comment


        • #5
          At first glance, the only differences between the expected and actual outputs are the line terminators, which is a typical problem when moving between Windows and *nix-based systems like OS X. I'll try to replicate this on my Windows machine.

          Comment


          • #6
            Fixed

            Those tests were indeed failing because of line separator differences. My last two commits for ROO-2658 fix those tests to work on any platform. Tested on OS X and Windows 7.

            Comment


            • #7
              Yes, and (of course) it is building here too.

              Comment


              • #8
                Great! Thanks for confirming that.

                Comment

                Working...
                X