Announcement Announcement Module
Collapse
No announcement yet.
InputApplicationDialog Page Title Module
Move Remove Collapse
X
Conversation Detail Module
Collapse
  • Filter
  • Time
  • Show
Clear All
new posts

  • InputApplicationDialog

    Hi,

    i've tried to use the InputApplicationDialog with the empty Constructor. It will not work:

    Code:
    InputApplicationDialog inputDialog = new InputApplicationDialog();
    inputDialog.setInputField( new JTextField());
    inputDialog.showDialog();
    Doing this a NullPointerException will be thrown, because the member formModel is null.

    Code:
    ERROR&#93; ApplicationAdvisor - null <java.lang.NullPointerException>java.lang.NullPointerException
    	at org.springframework.richclient.forms.SimpleValidationResultsReporter.initialize&#40;SimpleValidationResultsReporter.java&#58;56&#41;
    	at org.springframework.richclient.forms.SimpleValidationResultsReporter.<init>&#40;SimpleValidationResultsReporter.java&#58;52&#41;
    	at org.springframework.richclient.dialog.InputApplicationDialog.getValidationReporter&#40;InputApplicationDialog.java&#58;102&#41;
    	at org.springframework.richclient.dialog.InputApplicationDialog.createDialogContentPane&#40;InputApplicationDialog.java&#58;128&#41;
    	at org.springframework.richclient.dialog.ApplicationDialog.addDialogComponents&#40;ApplicationDialog.java&#58;479&#41;
    	at org.springframework.richclient.dialog.ApplicationDialog.createDialog&#40;ApplicationDialog.java&#58;283&#41;
    	at org.springframework.richclient.dialog.ApplicationDialog.showDialog&#40;ApplicationDialog.java&#58;252&#41;
    The Problem is that the FormModel is null and it will be used in the SimpleValidationResultsReporter. This class throws the NullPointer.

    I think we should check this in the InputApplicationDialog like:
    Code:
    private SimpleMessageAreaPane getValidationReporter&#40;&#41; &#123;
      if &#40;reporter == null&#41; &#123;
        this.reporter = new SimpleMessageAreaPane&#40;&#41;;
          if&#40; formModel != null&#41; // not sure if check here or at the first if
            new SimpleValidationResultsReporter&#40;formModel, this, this.reporter&#41;;
      &#125;
      return reporter;
    &#125;

    siu
    Claudio


    ps: does this belongs the developerlist?

    [/code]

  • #2
    Developer list or JIRA are probably best places for bugs.

    Thanks! Good catch!

    Comment


    • #3
      Forgot to mention: contributing test cases that catch these going forward would also be very helpful! Just something to keep in mind ;-)

      thanks again!

      Comment

      Working...
      X